User talk:GC345

Welcome
Hi, welcome to ! Thanks for your edit to the Tamamo page.

Please leave a message on my talk page if I can help with anything! Shadowblade777 (talk) 15:28, November 25, 2013 (UTC)

Script Fix: Fully Functional English Side Stories For Monster Girl Quest Part 3
Hello, GC345. I am TheGreatHeinrich, the guy who helped fix up the text display in the Monster Girl Quest Part 2 English patch. I see that you are continuously fixing the Monster Girl Quest Part 3 script after Rogue posted the last official English patch, and I would like to assist.

I downloaded your latest version of the English script (6 January 2014--check to see if you made any fixes after this because I didn't take that into account!) for Monster Girl Quest Part 3 and have made a few changes on my own. I don't know if I caught everything I wanted to yet. This includes: I wish to add more fixes, but for now I think this will suffice. If you have any questions, please message me on my talk page. Here is the file: http://www.mediafire.com/download/85ykhc0ie3jr0rd/0.zip
 * Making the Side Story module fully functional in English, including all the battle code.
 * Note: I haven't fully tested it yet. I took the working code from the English version of Monster Girl Quest Part 2 that had some extra features and put them into Monster Girl Quest Part 3. This includes the "@" and "\" at the end of each line of dialogue (this is completely optional).
 * Rewording the generic battle text to make everything gender neutral. This allows side stories to have a protagonist and/or enemies of either gender without forcing the protagonist to be male and the enemy to be female.
 * Fixing the battle window of Side Story battles with a protagonist other than Luka. For example, the Cecil Side Story.

The other huge thing I would like to do is make all strings that display using the "lsp" command not have to use a double-width space. I don't know how to explain this very well, but I will try. Back when Monster Girl Quest Part 2 was machine-translated, the guy added a function that inserted the BEL character (in the ASCII table, this is character code 7) in place of a space, so this in Rogue's script, for example: would have all the spaces be replaced with the BEL character. This can only be done on Notepad++. The result is that the output in-game would appear to have spaces.
 * if %skill01>0 lsp 301,":s/20,20,0;#FFFFFFJump　at　the enemy, and slash at　their neck. ",50,450

However, instead of inserting these characters this in the actual script, I have another idea. NScripter can be modded by writing Lua code. I created a small Lua file that takes any strings to be displayed by the "lsp" command, automatically replace all spaces with BEL characters, and automatically append a space to the end if need be so that NScripter doesn't randomly chew up the last character. All you need to do is place this file into the same folder as the mon_que.exe file. The catch: All "lsp" strings in the game script must be changed so that no instance of double-width (16-bit) characters exist; they should all really be single-width (8-bit) ASCII characters.

The benefits: You don't need to append a space to the end of every string any more, and you don't need to worry about NScripter eating up a space randomly. This includes Side Stories, which are probably what the majority of users will be touching.

The downsides: If the user is using a different font than what I am using, the spaces may appear as dots instead of spaces. I don't know how to fix this because I cannot reproduce this bug.

I'm in the middle of it and it should be done pretty soon, but for now I want to get the Side Stories to be fully compatible with Monster Girl Quest Part 3.

TheGreatHeinrich (talk) 17:06, January 7, 2014 (UTC)

Tnx for this fix and especially for the changelog.

I will add neutral gender, missed translations and eng $sel1:$sel6\ immediatedly. Others fixes - just a little later. After I try to understand how this Side Story block is working...

And tnx to the hint about Meditation.

Unfortunatedly there is no result for placing BEL. I have used Far Manager to insert this 0x0007 character. The result is this.

GC345 (talk) 18:49, January 7, 2014 (UTC)

I see. In that case, I don't know what else to do. Can you upload a copy of the game script you used in that screenshot? I'd like to look at it, if nothing else.

TheGreatHeinrich (talk) 19:11, January 7, 2014 (UTC)

It was just the Rogue's final patch with 2 edited strings. Have uploaded it on the hosting. P.S. Mon_que.exe crc32 is 7de2462b.

I will be happy if the trouble is on my side and there is a way to fix lsp in the nscripter version from MGQ3 english patch. I have tested onscripter-en with this game, but this branch can't work correctly with goto "*"+$lavel+"_a" construction. It looks like the + priority is too low. Only the mov $1,"*"+$lavel+"_a":goto $1 is working... And these gotos are the cornerstone of MGQ3 script...

GC345 (talk) 22:52, January 7, 2014 (UTC)

I did some more tinkering with Lua and I think I finally fixed the lsp string display. It still requires a Lua file to be placed in the same directory as the executable, and also it still requires a bunch of text in the game script to be fixed, for example:
 * No more ideographic spaces (\u3000): These are replaced with regular spaces
 * No more fullwidth Unicode characters mixed with halfwidth ASCII characters
 * (optional) No more spaces at the end

Also, was the "namecut" and "ori_nnn" name thing necessary? All you had to do was get rid of the space after the names in "ori_name" and "temp_name" without writing any new code. The only things that might still be affected are the side stories with custom battles, but for each battle you only change 2 things: the hero's name and the enemy's name.

Anyway, thanks for applying the fixes. That long code you see with the side story (the one with "mon_labo_mon_ini_cmd") is the one I used in Monster Girl Quest Part 2 before Rogue introduced Cecil's Adventure. I tested it and it should work with every side story.

TheGreatHeinrich (talk) 13:25, January 8, 2014 (UTC)